Bug 93253

Summary: Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
Product: WebKit Reporter: Sergey Rogulenko <rogulenko>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, gyuyoung.kim, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sergey Rogulenko
Reported 2012-08-06 04:03:03 PDT
Renaming files DOMNodeHighlighter.(h|cpp) to InspectorOverlay.(h|cpp) and deleting string "DOMNodeHighlighter" everywhere.
Attachments
Patch (85.04 KB, patch)
2012-08-06 04:06 PDT, Sergey Rogulenko 		no flags
DetailsFormatted DiffDiff
Patch (82.16 KB, patch)
2012-08-06 07:58 PDT, Sergey Rogulenko 		no flags
DetailsFormatted DiffDiff
Patch (82.08 KB, patch)
2012-08-06 08:29 PDT, Sergey Rogulenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sergey Rogulenko
Comment 1 2012-08-06 04:06:06 PDT
Created attachment 156651 [details] Patch
Andrey Kosyakov
Comment 2 2012-08-06 04:34:55 PDT
Comment on attachment 156651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156651&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1008 > + if (enabled) > + m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject); please split this into a separate change. > Source/WebCore/inspector/InspectorDOMAgent.cpp:1019 > + return PassOwnPtr<HighlightConfig> (); return nullptr?
Sergey Rogulenko
Comment 3 2012-08-06 07:58:10 PDT
Created attachment 156694 [details] Patch
Sergey Rogulenko
Comment 4 2012-08-06 08:29:46 PDT
Created attachment 156699 [details] Patch
WebKit Review Bot
Comment 5 2012-08-08 05:51:34 PDT
Comment on attachment 156699 [details] Patch Clearing flags on attachment: 156699 Committed r125025: <http://trac.webkit.org/changeset/125025>
WebKit Review Bot
Comment 6 2012-08-08 05:51:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.