Bug 93253

Summary: Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
Product: WebKit Reporter: Sergey Rogulenko <rogulenko>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, gyuyoung.kim, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Sergey Rogulenko 2012-08-06 04:03:03 PDT
Renaming files DOMNodeHighlighter.(h|cpp) to InspectorOverlay.(h|cpp) and deleting string "DOMNodeHighlighter" everywhere.
Comment 1 Sergey Rogulenko 2012-08-06 04:06:06 PDT
Created attachment 156651 [details]
Patch
Comment 2 Andrey Kosyakov 2012-08-06 04:34:55 PDT
Comment on attachment 156651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156651&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +    if (enabled)
> +        m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

please split this into a separate change.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1019
> +        return PassOwnPtr<HighlightConfig> ();

return nullptr?
Comment 3 Sergey Rogulenko 2012-08-06 07:58:10 PDT
Created attachment 156694 [details]
Patch
Comment 4 Sergey Rogulenko 2012-08-06 08:29:46 PDT
Created attachment 156699 [details]
Patch
Comment 5 WebKit Review Bot 2012-08-08 05:51:34 PDT
Comment on attachment 156699 [details]
Patch

Clearing flags on attachment: 156699

Committed r125025: <http://trac.webkit.org/changeset/125025>
Comment 6 WebKit Review Bot 2012-08-08 05:51:39 PDT
All reviewed patches have been landed.  Closing bug.