Bug 93253 - Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
Summary: Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 04:03 PDT by Sergey Rogulenko
Modified: 2012-08-08 05:51 PDT (History)
13 users (show)

See Also:

Attachments
Patch (85.04 KB, patch)
2012-08-06 04:06 PDT, Sergey Rogulenko 		no flags Details | Formatted Diff | Diff
Patch (82.16 KB, patch)
2012-08-06 07:58 PDT, Sergey Rogulenko 		no flags Details | Formatted Diff | Diff
Patch (82.08 KB, patch)
2012-08-06 08:29 PDT, Sergey Rogulenko 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Rogulenko 2012-08-06 04:03:03 PDT 
Renaming files DOMNodeHighlighter.(h|cpp) to InspectorOverlay.(h|cpp) and deleting string "DOMNodeHighlighter" everywhere.
Comment 1 Sergey Rogulenko 2012-08-06 04:06:06 PDT 
Created attachment 156651 [details]
Patch
Comment 2 Andrey Kosyakov 2012-08-06 04:34:55 PDT 
Comment on attachment 156651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156651&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +    if (enabled)
> +        m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

please split this into a separate change.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1019
> +        return PassOwnPtr<HighlightConfig> ();

return nullptr?
Comment 3 Sergey Rogulenko 2012-08-06 07:58:10 PDT 
Created attachment 156694 [details]
Patch
Comment 4 Sergey Rogulenko 2012-08-06 08:29:46 PDT 
Created attachment 156699 [details]
Patch
Comment 5 WebKit Review Bot 2012-08-08 05:51:34 PDT 
Comment on attachment 156699 [details]
Patch

Clearing flags on attachment: 156699

Committed r125025: <http://trac.webkit.org/changeset/125025>
Comment 6 WebKit Review Bot 2012-08-08 05:51:39 PDT 
All reviewed patches have been landed.  Closing bug.