Summary: | Handle variables in CSSParser::parseValidPrimitive(), preventing null return value. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||||
Component: | New Bugs | Assignee: | Luke Macpherson <macpherson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarcelo, kling, macpherson, menard, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Luke Macpherson
2012-08-06 01:40:20 PDT
Created attachment 156623 [details]
Patch
Comment on attachment 156623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156623&action=review > Source/WebCore/css/CSSParser.cpp:1642 > + if (value->unit == CSSPrimitiveValue::CSS_VARIABLE_NAME) Why are variables a unit type? I think I need to study how variables are implemented a bit before I'm qualified to review this. dglazkov can probably review this before I get to it tomorrow. > LayoutTests/fast/css/variables/invalid-font-reference.html:2 > +<script> > +if (window.testRunner) Nit: We normally include the <!DOCTYPE html> and <html> tag for new tests unless you're intentionally testing quirks mode. Created attachment 156792 [details]
Patch
Comment on attachment 156792 [details] Patch Clearing flags on attachment: 156792 Committed r124833: <http://trac.webkit.org/changeset/124833> All reviewed patches have been landed. Closing bug. |