| Summary: | LayoutTest: fast/forms/validation-message-user-modify.html fails (adding to skiplist platform/win/Skipped) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||||
| Component: | Forms | Assignee: | Roger Fong <roger_fong> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | jonlee, michelangelo, shinyak, thorton, webkit.review.bot | ||||||||||
| Priority: | P2 | Keywords: | LayoutTestFailure, MakingBotsRed | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Roger Fong
2012-08-05 14:12:09 PDT
Is there a bug tracking this work? (In reply to comment #0) > The 'required' property for forms has not yet been implemented. > This test should not be run and was not added to the Windows skip list. See <rdar://problem/11965018> for associated enhancement bug. (In reply to comment #2) > (In reply to comment #0) > > The 'required' property for forms has not yet been implemented. > > This test should not be run and was not added to the Windows skip list. > > See <rdar://problem/11965018> for associated enhancement bug. There ought to be a bugzilla bug. And I wonder why there's a test if it's not implemented? O and yes this test uses the required property to force a validation window to pop up, and then tests the bubble to make sure that it is read only. Since the required property is not implemented though, the test fails. Perhaps we should just create a new test case that does work with this with some javascripting. (Or wait for just wait for the feature to be implemented and then remove this test from the skip list) I'll create a bugzilla bug to associate with the radar. It looks to me like it's expected to be implemented: https://bugs.webkit.org/show_bug.cgi?id=25551 Ah looks like it. I'll associate the radar with that one. So should I bother adding the test to the skip list then if it's expected? I guess one could say 'for the sake of making the bots greener' ... not that that means much. (In reply to comment #8) > So should I bother adding the test to the skip list then if it's expected? I guess one could say 'for the sake of making the bots greener' ... not that that means much. I think you should! And you should remove the "required property not yet implemented" bit from this bugs title, and Cc the authors of the test and maybe the people who implemented "required", etc. Created attachment 156569 [details]
Adding test to skip list
Correction: The required attribute is now broken. Was working after https://bugs.webkit.org/show_bug.cgi?id=25551 but has since regressed. Temporarily adding test to skip list and filing new bug for regression. (In reply to comment #11) > Correction: The required attribute is now broken. > Was working after https://bugs.webkit.org/show_bug.cgi?id=25551 > but has since regressed. Temporarily adding test to skip list and filing new bug for regression. Correction to correction: I have no idea if it ever worked on safari. Things to note: -Mac: test passes because if the validation bubble doesn't appear, then the test tries to modify nothing, which makes the before and after states of the page the same, causing the test to pass -Windows: internals reference does not exist, seems to be problems with Windows testing infrastructure -In general: If anyone knows whether or not this ever worked in Safari let me know. There seems to be minor evidence that it did to some extent from what I've found online but nothing conclusive. If it did, I'll file a regression bug, if not I'll just file a bug bug. For now the test is just being slapped on the skip list on Windows to help with the green-liness. Created attachment 156778 [details]
Adjust patch comments
This feature has never worked in safari, the hooks are there but the browser does not use them yet. Thanks Jon Created attachment 156791 [details]
More comment changes
Created attachment 156804 [details]
style corrections
Comment on attachment 156804 [details] style corrections Clearing flags on attachment: 156804 Committed r124831: <http://trac.webkit.org/changeset/124831> All reviewed patches have been landed. Closing bug. |