Bug 93165

Summary: [chromium] Add gyp variable to control which compositor target is depended on
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, enne, fishd, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93309    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description James Robinson 2012-08-03 16:06:15 PDT 
[chromium] Add gyp variable to control which compositor target is depended on
Comment 1 James Robinson 2012-08-03 16:06:43 PDT 
Created attachment 156474 [details]
Patch
Comment 2 James Robinson 2012-08-03 16:07:14 PDT 
Just posting as an FYI for now, gyp will barf on this since <(DEPTH)/cc/cc.gyp does not exist yet.
Comment 3 Adam Barth 2012-08-03 16:14:37 PDT 
Comment on attachment 156474 [details]
Patch

Don't you also need to add cc to DEPS?
Comment 4 James Robinson 2012-08-03 21:27:31 PDT 
Created attachment 156511 [details]
Patch
Comment 5 James Robinson 2012-08-03 21:30:34 PDT 
https://chromiumcodereview.appspot.com/10824175/ has to land first or gclient will die processing the new DEPS entry.
Comment 6 Adam Barth 2012-08-03 23:32:08 PDT 
Comment on attachment 156511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156511&action=review

> Source/WebCore/WebCore.gyp/WebCore.gyp:2154
> +        }, { # use_webkit_compositor==0

use_webkit_compositor -> use_libcc_for_compositor ?
Comment 7 James Robinson 2012-08-06 18:54:18 PDT 
Created attachment 156826 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-08-06 21:00:11 PDT 
Comment on attachment 156826 [details]
Patch for landing

Clearing flags on attachment: 156826

Committed r124845: <http://trac.webkit.org/changeset/124845>
Comment 9 WebKit Review Bot 2012-08-06 21:00:15 PDT 
All reviewed patches have been landed.  Closing bug.