Summary: | [Qt] UI_SIDE_COMPOSITING code has confusing names | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||||
Component: | New Bugs | Assignee: | Noam Rosenthal <noam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cmarcelo, gustavo, gyuyoung.kim, hausmann, jturcotte, kenneth, levin+threading, luiz, menard, rakuco, vestbo, webkit.review.bot, xan.lopez, youngtaeck.song, zoltan | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Noam Rosenthal
2012-08-03 15:54:02 PDT
The idea is to use CoordinatedGraphics as the directory and USE(COORDINATED_GRAPHICS) instead of USE(UI_SIDE_COMPOSITING). Renames: LayerBackingStore -> CoordinatedBackingStore WebGraphicsLayer -> CoordinatedGraphicsLayer WebLayerTreeRenderer -> LayerTreeRenderer TiledBackingStoreRemoteTile -> CoordinatedTile Yes sounds very good Created attachment 156473 [details]
Patch
Comment on attachment 156473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156473&action=review I'd appreciate if if you kept the file list in WebKit2/CMakeLists.txt alphabetically sorted. > Source/WebKit2/CMakeLists.txt:224 > - UIProcess/LayerTreeCoordinatorProxy.cpp > + UIProcess/CoordinatedGraphics/ayerTreeCoordinatorProxy.cpp Typo. Created attachment 156481 [details]
Fixed CMakeLists.txt alphabetical order
Comment on attachment 156481 [details] Fixed CMakeLists.txt alphabetical order Attachment 156481 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13430579 Created attachment 156484 [details]
Removed unnecessary files from GTK build
Comment on attachment 156484 [details] Removed unnecessary files from GTK build Attachment 156484 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13431528 Created attachment 156490 [details]
Renamed file in CMakeLists
Comment on attachment 156490 [details] Renamed file in CMakeLists Clearing flags on attachment: 156490 Committed r124701: <http://trac.webkit.org/changeset/124701> All reviewed patches have been landed. Closing bug. |