Bug 93164

Summary: [Qt] UI_SIDE_COMPOSITING code has confusing names
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: New BugsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, gustavo, gyuyoung.kim, hausmann, jturcotte, kenneth, levin+threading, luiz, menard, rakuco, vestbo, webkit.review.bot, xan.lopez, youngtaeck.song, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixed CMakeLists.txt alphabetical order
none
Removed unnecessary files from GTK build
none
Renamed file in CMakeLists none

Noam Rosenthal
Reported 2012-08-03 15:54:02 PDT
[Qt] UI_SIDE_COMPOSITING code has confusing names
Attachments
Patch (262.05 KB, patch)
2012-08-03 16:03 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Fixed CMakeLists.txt alphabetical order (262.82 KB, patch)
2012-08-03 16:46 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Removed unnecessary files from GTK build (263.61 KB, patch)
2012-08-03 17:06 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Renamed file in CMakeLists (263.62 KB, patch)
2012-08-03 17:41 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-08-03 15:55:51 PDT
The idea is to use CoordinatedGraphics as the directory and USE(COORDINATED_GRAPHICS) instead of USE(UI_SIDE_COMPOSITING). Renames: LayerBackingStore -> CoordinatedBackingStore WebGraphicsLayer -> CoordinatedGraphicsLayer WebLayerTreeRenderer -> LayerTreeRenderer TiledBackingStoreRemoteTile -> CoordinatedTile
Kenneth Rohde Christiansen
Comment 2 2012-08-03 15:58:29 PDT
Yes sounds very good
Noam Rosenthal
Comment 3 2012-08-03 16:03:47 PDT
Created attachment 156473 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-08-03 16:18:11 PDT
Comment on attachment 156473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156473&action=review I'd appreciate if if you kept the file list in WebKit2/CMakeLists.txt alphabetically sorted. > Source/WebKit2/CMakeLists.txt:224 > - UIProcess/LayerTreeCoordinatorProxy.cpp > + UIProcess/CoordinatedGraphics/ayerTreeCoordinatorProxy.cpp Typo.
Noam Rosenthal
Comment 5 2012-08-03 16:46:38 PDT
Created attachment 156481 [details] Fixed CMakeLists.txt alphabetical order
Gustavo Noronha (kov)
Comment 6 2012-08-03 16:56:17 PDT
Comment on attachment 156481 [details] Fixed CMakeLists.txt alphabetical order Attachment 156481 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13430579
Noam Rosenthal
Comment 7 2012-08-03 17:06:41 PDT
Created attachment 156484 [details] Removed unnecessary files from GTK build
Gyuyoung Kim
Comment 8 2012-08-03 17:28:45 PDT
Comment on attachment 156484 [details] Removed unnecessary files from GTK build Attachment 156484 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13431528
Noam Rosenthal
Comment 9 2012-08-03 17:41:32 PDT
Created attachment 156490 [details] Renamed file in CMakeLists
WebKit Review Bot
Comment 10 2012-08-04 10:52:54 PDT
Comment on attachment 156490 [details] Renamed file in CMakeLists Clearing flags on attachment: 156490 Committed r124701: <http://trac.webkit.org/changeset/124701>
WebKit Review Bot
Comment 11 2012-08-04 10:53:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.