Bug 93157

Summary:

DFG::StructureCheckHoistingPhase keeps a Node& around for too long

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, mhahnenberg

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

92691

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Filip Pizlo 2012-08-03 14:15:37 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2012-08-03 14:19:45 PDT

Created attachment 156456 [details]
the patch

Comment 2 Mark Hahnenberg 2012-08-03 14:32:16 PDT

Comment on attachment 156456 [details]
the patch

Maybe add a comment above the declaration of the Node warning future travelers that they should be careful not to use it after the append? Other than that, looks good.

Comment 3 Filip Pizlo 2012-08-03 14:42:11 PDT

Landed in http://trac.webkit.org/changeset/124655