Bug 93157

Summary: DFG::StructureCheckHoistingPhase keeps a Node& around for too long
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 92691    
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2012-08-03 14:15:37 PDT
Patch forthcoming.
Attachments
the patch (3.73 KB, patch)
2012-08-03 14:19 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-08-03 14:19:45 PDT
Created attachment 156456 [details] the patch
Mark Hahnenberg
Comment 2 2012-08-03 14:32:16 PDT
Comment on attachment 156456 [details] the patch Maybe add a comment above the declaration of the Node warning future travelers that they should be careful not to use it after the append? Other than that, looks good.
Filip Pizlo
Comment 3 2012-08-03 14:42:11 PDT
Landed in http://trac.webkit.org/changeset/124655
Note You need to log in before you can comment on or make changes to this bug.