Bug 93157 - DFG::StructureCheckHoistingPhase keeps a Node& around for too long
Summary: DFG::StructureCheckHoistingPhase keeps a Node& around for too long
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 92691
  Show dependency treegraph
Reported: 2012-08-03 14:15 PDT by Filip Pizlo
Modified: 2012-08-03 14:42 PDT (History)
2 users (show)

See Also:

the patch (3.73 KB, patch)
2012-08-03 14:19 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-08-03 14:15:37 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2012-08-03 14:19:45 PDT
Created attachment 156456 [details]
the patch
Comment 2 Mark Hahnenberg 2012-08-03 14:32:16 PDT
Comment on attachment 156456 [details]
the patch

Maybe add a comment above the declaration of the Node warning future travelers that they should be careful not to use it after the append? Other than that, looks good.
Comment 3 Filip Pizlo 2012-08-03 14:42:11 PDT
Landed in http://trac.webkit.org/changeset/124655