Bug 93147

Summary: [Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: dongseong.hwang, hausmann, jturcotte, kenneth, kim.1.gronholm, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93146    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Noam Rosenthal
Reported 2012-08-03 11:44:17 PDT
As a preparation for threaded animations (93146), we should use an animation controller that doesn't use re-layouts and is synchronized with requestAnimationFrame, GraphicsLayerAnimation.
Attachments
Patch (18.23 KB, patch)
2012-08-06 10:59 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.25 KB, patch)
2012-08-06 13:19 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.26 KB, patch)
2012-08-06 13:29 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-08-06 10:59:29 PDT
Created attachment 156725 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-08-06 12:25:20 PDT
Comment on attachment 156725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156725&action=review I think this looks fine. > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:792 > + bool hasBigRotation; shouldnt this be initialized? or is it an ignored value? like ignoredHasBigRotation; > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:818 > + > + double newline > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:218 > + > + double newline
Noam Rosenthal
Comment 3 2012-08-06 13:19:22 PDT
Created attachment 156752 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-08-06 13:22:47 PDT
Comment on attachment 156752 [details] Patch for landing Rejecting attachment 156752 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13437876
Noam Rosenthal
Comment 5 2012-08-06 13:29:00 PDT
Created attachment 156754 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-08-06 16:01:22 PDT
Comment on attachment 156754 [details] Patch for landing Clearing flags on attachment: 156754 Committed r124805: <http://trac.webkit.org/changeset/124805>
WebKit Review Bot
Comment 7 2012-08-06 16:01:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.