Bug 93143
| Summary: | Negative timestamps for TextTrackCue | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anna Cavender <annacc> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, eric.carlson, jer.noble, syoichi, vcarbune, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 128412, 85035 | ||
Anna Cavender
It is not clear what the expected behavior is when negative startTime and endTime values are specified for TextTrackCue objects. This is currently being discussed at the WHATWG:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18480
Once a decision has been made, this bug will implement the solution.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Carlson
http://trac.webkit.org/changeset/124645 changed our behavior, but leaving this open pending resolution of the w3c bug.
Eric Carlson
The changes made for r124645 are incorrect, the spec now says:
The text track cue start time and text track cue end time can be negative. (The current playback position can never be negative, though, so cues entirely before time zero cannot be active.)
Ahmad Saleem
Blink Commit (for Merge): https://chromium-review.googlesource.com/c/chromium/src/+/863270
^ Locally doing this make us pass at least two WPT test. Can give it a go?
@Eric - any recommendation?
Eric Carlson
(In reply to Ahmad Saleem from comment #3)
> Blink Commit (for Merge):
> https://chromium-review.googlesource.com/c/chromium/src/+/863270
>
> ^ Locally doing this make us pass at least two WPT test. Can give it a go?
>
> @Eric - any recommendation?
Yes, I think it would be good to make this change.
Radar WebKit Bug Importer
<rdar://problem/113035924>
EWS
Committed 267042@main (fb0116deed64): <https://commits.webkit.org/267042@main>
Reviewed commits have been landed. Closing PR #16165 and removing active labels.