Bug 93141

Summary: [BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jkjiang, jpetsovits, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Description Yong Li 2012-08-03 10:46:39 PDT
It is neither safe nor efficient to paint contents in this function
Comment 1 Yong Li 2012-08-03 10:56:48 PDT
Created attachment 156418 [details]
the patch
Comment 2 Rob Buis 2012-08-03 11:10:45 PDT
Comment on attachment 156418 [details]
the patch

LGTM.
Comment 3 Antonio Gomes 2012-08-03 11:17:57 PDT
Conscidence or not, this crash started appearing after Jakob's count-based suspend/resume backingstore patch.

cc him, as he last touched it.
Comment 4 Antonio Gomes 2012-08-03 11:18:28 PDT
Jacky, Pepeto: feel free to comment...
Comment 5 Yong Li 2012-08-03 11:24:43 PDT
Comment on attachment 156418 [details]
the patch

cancelling for now
Comment 6 Yong Li 2012-08-03 11:37:55 PDT
Comment on attachment 156418 [details]
the patch

commit again. with nested suspend/resume, it is no longer safe to leave a single suspend call there. we can easily strip off the message when we find a better solution
Comment 7 WebKit Review Bot 2012-08-03 12:58:34 PDT
Comment on attachment 156418 [details]
the patch

Clearing flags on attachment: 156418

Committed r124643: <http://trac.webkit.org/changeset/124643>
Comment 8 WebKit Review Bot 2012-08-03 12:58:38 PDT
All reviewed patches have been landed.  Closing bug.