Bug 93124

Summary:

[BlackBerry] InspectorOverlay class duplicated in WebCore

Product:

WebKit

Reporter:

Konrad Piascik <kpiascik>

Component:

WebKit BlackBerry

Assignee:

Konrad Piascik <kpiascik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, mifenton, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

90880

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Konrad Piascik

Reported 2012-08-03 07:54:47 PDT

https://bugs.webkit.org/show_bug.cgi?id=90880 refactored DOMNodeHighligher to include a new class WebCore::InspectorOverlay. A WebCore::InspectorOverlay class already exists in Source/WebKit/BlackBerry/WebCoreSupport/InspectorOverlay.h This bug will change the namespace of the class to BlackBerry::WebKit from WebCore to resolve this conflict.

Attachments
Patch (10.26 KB, patch) 2012-08-03 08:47 PDT, Konrad Piascik	no flags	Details Formatted Diff Diff
Patch (13.91 KB, patch) 2012-08-03 12:58 PDT, Konrad Piascik	no flags	Details Formatted Diff Diff
Patch (15.52 KB, patch) 2012-08-07 11:12 PDT, Konrad Piascik	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Konrad Piascik

Comment 1 2012-08-03 08:47:33 PDT

Created attachment 156389 [details] Patch

Rob Buis

Comment 2 2012-08-03 08:49:33 PDT

Comment on attachment 156389 [details] Patch LGTM.

Antonio Gomes

Comment 3 2012-08-03 09:25:59 PDT

Comment on attachment 156389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review > Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32 > -namespace WebCore { > +namespace BlackBerry { > +namespace WebKit { > I think it should be in WebKitSupport instead, no?

Konrad Piascik

Comment 4 2012-08-03 10:31:02 PDT

(In reply to comment #3) > (From update of attachment 156389 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review > > > Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32 > > -namespace WebCore { > > +namespace BlackBerry { > > +namespace WebKit { > > > > I think it should be in WebKitSupport instead, no? Is it OK to have the move as a separate commit?

WebKit Review Bot

Comment 5 2012-08-03 12:36:34 PDT

Comment on attachment 156389 [details] Patch Clearing flags on attachment: 156389 Committed r124639: <http://trac.webkit.org/changeset/124639>

WebKit Review Bot

Comment 6 2012-08-03 12:36:38 PDT

All reviewed patches have been landed. Closing bug.

Konrad Piascik

Comment 7 2012-08-03 12:58:56 PDT

Reopening to attach new patch.

Konrad Piascik

Comment 8 2012-08-03 12:58:58 PDT

Created attachment 156441 [details] Patch