Summary: | [BlackBerry] InspectorOverlay class duplicated in WebCore | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konrad Piascik <kpiascik> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Konrad Piascik <kpiascik> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, mifenton, rakuco, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 90880 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Konrad Piascik
2012-08-03 07:54:47 PDT
Created attachment 156389 [details]
Patch
Comment on attachment 156389 [details]
Patch
LGTM.
Comment on attachment 156389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review > Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32 > -namespace WebCore { > +namespace BlackBerry { > +namespace WebKit { > I think it should be in WebKitSupport instead, no? (In reply to comment #3) > (From update of attachment 156389 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review > > > Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32 > > -namespace WebCore { > > +namespace BlackBerry { > > +namespace WebKit { > > > > I think it should be in WebKitSupport instead, no? Is it OK to have the move as a separate commit? Comment on attachment 156389 [details] Patch Clearing flags on attachment: 156389 Committed r124639: <http://trac.webkit.org/changeset/124639> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 156441 [details]
Patch
Comment on attachment 156441 [details]
Patch
forgot cmake changes
Created attachment 156959 [details]
Patch
Comment on attachment 156959 [details]
Patch
LGTM.
Comment on attachment 156959 [details] Patch Clearing flags on attachment: 156959 Committed r124905: <http://trac.webkit.org/changeset/124905> All reviewed patches have been landed. Closing bug. |