Bug 93110

Summary: [Chromium] Add stubs for the find-in-page match rects API
Product: WebKit Reporter: Leandro Graciá Gil <leandrogracia>
Component: WebKit APIAssignee: Leandro Graciá Gil <leandrogracia>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91648, 93111    
Attachments:
Description Flags
Patch
none
Patch none

Description Leandro Graciá Gil 2012-08-03 07:05:28 PDT
The Android port allows tapping on the find-in-page result tickmarks taking the user to the corresponding matches. This functionality requires new methods in the WebFrame API.

In order to achieve WebKit API compatibility as soon as possible we're landing first empty stubs of these new methods leaving the implementation to a later bug.
Comment 1 Leandro Graciá Gil 2012-08-03 07:12:52 PDT
Created attachment 156365 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-03 07:14:58 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-08-03 10:13:49 PDT
Comment on attachment 156365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156365&action=review

Thanks.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1945
> +    // FIXME(leandrogracia): implement this as part of https://bugs.webkit.org/show_bug.cgi?id=93111.

FIXME(leandrogracia) -> FIXME

WebKit doesn't use user names in FIXME comments.

implement -> Implement

We try to use English sentence punctuation in comments.
Comment 4 Leandro Graciá Gil 2012-08-03 10:26:10 PDT
Created attachment 156409 [details]
Patch
Comment 5 Leandro Graciá Gil 2012-08-03 10:26:21 PDT
Comment on attachment 156365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156365&action=review

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1945
>> +    // FIXME(leandrogracia): implement this as part of https://bugs.webkit.org/show_bug.cgi?id=93111.
> 
> FIXME(leandrogracia) -> FIXME
> 
> WebKit doesn't use user names in FIXME comments.
> 
> implement -> Implement
> 
> We try to use English sentence punctuation in comments.

Done.
Comment 6 Adam Barth 2012-08-03 10:27:46 PDT
Comment on attachment 156409 [details]
Patch

Thanks.
Comment 7 Leandro Graciá Gil 2012-08-03 10:28:43 PDT
(In reply to comment #6)
> (From update of attachment 156409 [details])
> Thanks.

Np. Thanks for reviewing.
Comment 8 WebKit Review Bot 2012-08-03 12:46:00 PDT
Comment on attachment 156409 [details]
Patch

Clearing flags on attachment: 156409

Committed r124640: <http://trac.webkit.org/changeset/124640>
Comment 9 WebKit Review Bot 2012-08-03 12:46:05 PDT
All reviewed patches have been landed.  Closing bug.