[V8] StringCache::m_lastStringImpl and StringCache::m_lastV8String should be in sync

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

Background: I'm fixing memory leak and crash around StringCache in V8.

StringCache::m_lastStringImpl caches a StringImpl that was accessed most recently. StringCache::m_lastV8String caches Persistent<String> corresponding to the StringImpl. Hence m_lastStringImpl and m_lastV8String should be in sync.

However, StringCache::remove() breaks the sync. StringCache::remove() clears m_lastStringImpl but does not clear m_lastV8String. As far as I analyze the code, this won't cause any problem, but we should fix it just in case.

[Kentaro Hara]

Created attachment 156254 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 156254 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 156254 [details]
Patch

Rejecting attachment 156254 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
]" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/V8Binding.cpp
Hunk #1 FAILED at 470.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Binding.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13448743

[Kentaro Hara]

Created attachment 157052 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 157052 [details]
patch for landing

Clearing flags on attachment: 157052

Committed r124977: <http://trac.webkit.org/changeset/124977>