Bug 93065 - [V8] StringCache::m_lastStringImpl and StringCache::m_lastV8String should be in sync
Summary: [V8] StringCache::m_lastStringImpl and StringCache::m_lastV8String should be ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 21:36 PDT by Kentaro Hara
Modified: 2012-08-07 21:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2012-08-02 21:38 PDT, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (2.01 KB, patch)
2012-08-07 17:23 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-02 21:36:20 PDT
Background: I'm fixing memory leak and crash around StringCache in V8.

StringCache::m_lastStringImpl caches a StringImpl that was accessed most recently. StringCache::m_lastV8String caches Persistent<String> corresponding to the StringImpl. Hence m_lastStringImpl and m_lastV8String should be in sync.

However, StringCache::remove() breaks the sync. StringCache::remove() clears m_lastStringImpl but does not clear m_lastV8String. As far as I analyze the code, this won't cause any problem, but we should fix it just in case.
Comment 1 Kentaro Hara 2012-08-02 21:38:16 PDT
Created attachment 156254 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-07 15:33:41 PDT
Comment on attachment 156254 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2012-08-07 15:58:10 PDT
Comment on attachment 156254 [details]
Patch

Rejecting attachment 156254 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
]" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/V8Binding.cpp
Hunk #1 FAILED at 470.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Binding.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13448743
Comment 4 Kentaro Hara 2012-08-07 17:23:59 PDT
Created attachment 157052 [details]
patch for landing
Comment 5 WebKit Review Bot 2012-08-07 21:01:41 PDT
Comment on attachment 157052 [details]
patch for landing

Clearing flags on attachment: 157052

Committed r124977: <http://trac.webkit.org/changeset/124977>