| Summary: | [chromium] Move ubercomp quads back into CC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexandre Elias <aelias> | ||||||
| Component: | New Bugs | Assignee: | Alexandre Elias <aelias> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, aelias, cc-bugs, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, nduca, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexandre Elias
2012-08-02 19:13:48 PDT
Created attachment 156239 [details]
Patch
Thank goodness for regexps and regularized naming conventions :). Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 156239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156239&action=review Could you fix the .gyp and reupload for EWS? > Source/Platform/Platform.gypi:123 > - 'chromium/public/WebTransformationMatrix.h', > + 'chromium/public/WebKit::WebTransformationMatrix.h', I think your regex went a bit awry here - this probably won't work > Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.h:36 > +class CCSharedQuadState { > +public: Can you just make this be a struct? > Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.h:48 > + CCSharedQuadState(); Do you need this? Created attachment 156243 [details]
Patch
Fixed gyp mistake and changed CCSharedQuadState
Comment on attachment 156243 [details] Patch Clearing flags on attachment: 156243 Committed r124621: <http://trac.webkit.org/changeset/124621> All reviewed patches have been landed. Closing bug. |