Bug 93035

Summary: writeHelperGetString in V8HTMLDocument uses += to concatenate strings
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: WebCore JavaScriptAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jaepark
Priority: P2 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2012-08-02 15:26:35 PDT
writeHelperGetString in V8HTMLDocument uses += to concatenate strings Requested by abarth on #webkit.
Attachments
Patch (1.95 KB, patch)
2012-08-08 17:04 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-02 15:29:47 PDT
This should use StringBuilder instead. Feel free to steal this bug from me.
Jae Hyun Park
Comment 2 2012-08-08 17:04:32 PDT
Created attachment 157340 [details] Patch
Adam Barth
Comment 3 2012-08-08 17:05:33 PDT
Comment on attachment 157340 [details] Patch Yay! Thanks!
WebKit Review Bot
Comment 4 2012-08-08 18:10:16 PDT
Comment on attachment 157340 [details] Patch Clearing flags on attachment: 157340 Committed r125132: <http://trac.webkit.org/changeset/125132>
WebKit Review Bot
Comment 5 2012-08-08 18:10:20 PDT
All reviewed patches have been landed. Closing bug.
Jae Hyun Park
Comment 6 2012-08-08 18:41:16 PDT
(In reply to comment #3) > (From update of attachment 157340 [details]) > Yay! Thanks! Thank you for your review.
Note You need to log in before you can comment on or make changes to this bug.