Summary: | [EFL] Build failures with harfbuzz outside standard locations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||
Component: | WebKit EFL | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | d-r, glima, gyuyoung.kim, lucas.de.marchi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Raphael Kubo da Costa (:rakuco)
2012-08-02 14:32:15 PDT
I've finished building here and couldn't reproduce the issue (I was able to do so on another system). The harfbuzz include path seems to be added via EVAS_INCLUDE_DIRS, as `pkg-config --cflags-only-I evas' returns, among others, -I${WEBKITOUTPUUTDIR}/Dependencies/Root/include/harfbuzz. Are you building the port with build-webkit or using CMake on your own? In case it's the latter, I suspect evas may have been built without harfbuzz support and the flag is thus absent from your evas.pc. In case it's the former, I'd like to see the output of `./Tools/efl/run-with-jhbuild pkg-config --cflags-only-I evas'. (In reply to comment #1) > The harfbuzz include path seems to be added via EVAS_INCLUDE_DIRS, as `pkg-config --cflags-only-I evas' returns, among others, -I${WEBKITOUTPUUTDIR}/Dependencies/Root/include/harfbuzz. (Relying on this is wrong, by the way, but I'd like to pinpoint where the problem is before trying to fix it). (In reply to comment #1) > I've finished building here and couldn't reproduce the issue (I was able to do so on another system). ... Thinking of it again, I was able to reproduce this when I was testing my FindEFL.cmake rewrite, which gets rid of those implicit dependencies I mentioned in the previous comments, so it makes sense to have experienced the same build problem. The problem occurs with a build without build-webkit usage, but pristine cmake. Evas without harfbuzz linkage too. I've just found out that a harfbuzzy Evas will let the build go, but apparently this should not be a requirement. My 2 cents. Created attachment 159850 [details]
Patch
Makes sense to me, thanks for catching this. Comment on attachment 159850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159850&action=review LGTM. > Source/WebCore/PlatformEfl.cmake:158 > + ${HARFBUZZ_INCLUDE_DIRS} Is the indenting correct here? Yep, we're just not using quotes. Comment on attachment 159850 [details] Patch Clearing flags on attachment: 159850 Committed r126305: <http://trac.webkit.org/changeset/126305> All reviewed patches have been landed. Closing bug. |