Bug 92999

Summary: Web Inspector: Make textModel private to textEditor
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Jan Keromnes <janx>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Jan Keromnes
Reported 2012-08-02 09:16:48 PDT
The textModel belongs to the textEditor and should be private to it. Currently, it is created outside textEditor and is sometimes accessed directly by a SourceFrame, JavaScriptSourceFrame or UISourceCodeFrame.
Attachments
Patch (16.91 KB, patch)
2012-08-02 12:19 PDT, Jan Keromnes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Keromnes
Comment 1 2012-08-02 12:19:34 PDT
Created attachment 156137 [details] Patch
WebKit Review Bot
Comment 2 2012-08-03 02:03:21 PDT
Comment on attachment 156137 [details] Patch Clearing flags on attachment: 156137 Committed r124584: <http://trac.webkit.org/changeset/124584>
WebKit Review Bot
Comment 3 2012-08-03 02:03:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.