Summary: | [CSS Regions] region-overflow: break still renders the content that does not fit in the last region. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Balan <mibalan> | ||||||||
Component: | CSS | Assignee: | Mihnea Ovidenie <mihnea> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, jchaffraix, mihnea, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 57312 | ||||||||||
Attachments: |
|
Description
Mihai Balan
2012-08-02 08:54:01 PDT
Created attachment 156101 [details]
Ref test highlighting the problem
Created attachment 156526 [details]
Patch
Comment on attachment 156526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156526&action=review The change looks fine. By the way - probably related - but shouldn't RenderBlock::hasNextPage be changed too? AFAICT we shouldn't have an extra page after the last region if it has region-overflow: break but the code seems to imply that we do. > LayoutTests/fast/regions/region-overflow-break-expected.html:15 > +#gray { > overflow:visible; > } This doesn't look fine but I guess it is expected because we don't implement forced region breaking. I would put a FIXME as it's confusing if you don't know our current implementation. Created attachment 157695 [details]
Patch for landing
Comment on attachment 157695 [details] Patch for landing Clearing flags on attachment: 157695 Committed r125271: <http://trac.webkit.org/changeset/125271> All reviewed patches have been landed. Closing bug. |