Bug 92994

Summary: Web Inspector: extend test coverage for nmi code.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87262, 93001    
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-08-02 08:49:02 PDT
There were 2 cases. 1) owner object type propagation. If a class with object type DOM has an instrumented member with object type Other then it has to be recorded as DOM. Sample: We have SharedBuffer class and we don't know the object type for it but we know that it is owned by an object with type CachedResourceImage. 2) the first member of an instrumented non virtual class was skipped even if it was reported properly. it happened because the first member has the same address as it's owner
Attachments
Patch (17.14 KB, patch)
2012-08-02 08:54 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-08-02 08:54:30 PDT
Created attachment 156099 [details] Patch
Yury Semikhatsky
Comment 2 2012-08-02 23:26:29 PDT
Comment on attachment 156099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156099&action=review > Source/WebCore/ChangeLog:8 > + 2 cases were fixed. This patch is not only about tests, it fixes two bugs and this comment may confuse people.
Ilya Tikhonovsky
Comment 3 2012-08-03 00:34:18 PDT
Committed r124570: <http://trac.webkit.org/changeset/124570>
Note You need to log in before you can comment on or make changes to this bug.