Bug 92994 - Web Inspector: extend test coverage for nmi code.
Summary: Web Inspector: extend test coverage for nmi code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 87262 93001
  Show dependency treegraph
 
Reported: 2012-08-02 08:49 PDT by Ilya Tikhonovsky
Modified: 2012-08-03 00:34 PDT (History)
11 users (show)

See Also:


Attachments
Patch (17.14 KB, patch)
2012-08-02 08:54 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-08-02 08:49:02 PDT
There were 2 cases. 
1) owner object type propagation. If a class with object type DOM has an instrumented member with object type Other then it has to be recorded as DOM.
Sample: We have SharedBuffer class and we don't know the object type for it but we know that it is owned by an object with type CachedResourceImage.

2) the first member of an instrumented non virtual class was skipped even if it was reported properly.
it happened because the first member has the same address as it's owner
Comment 1 Ilya Tikhonovsky 2012-08-02 08:54:30 PDT
Created attachment 156099 [details]
Patch
Comment 2 Yury Semikhatsky 2012-08-02 23:26:29 PDT
Comment on attachment 156099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156099&action=review

> Source/WebCore/ChangeLog:8
> +        2 cases were fixed.

This patch is not only about tests, it fixes two bugs and this comment may confuse people.
Comment 3 Ilya Tikhonovsky 2012-08-03 00:34:18 PDT
Committed r124570: <http://trac.webkit.org/changeset/124570>