Bug 92978

Summary: [Qt] MSVC specific buildfix for DRT.
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kbalazs, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
drt-fix-msvc
none
drt-fix-msvc none

Zoltan Arvai
Reported 2012-08-02 05:08:16 PDT
Include for DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build. It's need to be added to DumpRenderTree.pro file.
Attachments
drt-fix-msvc (1.04 KB, patch)
2012-08-02 05:09 PDT, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
drt-fix-msvc (1.06 KB, patch)
2012-08-02 05:22 PDT, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2012-08-02 05:09:18 PDT
Created attachment 156042 [details] drt-fix-msvc
Csaba Osztrogonác
Comment 2 2012-08-02 05:15:59 PDT
Comment on attachment 156042 [details] drt-fix-msvc View in context: https://bugs.webkit.org/attachment.cgi?id=156042&action=review > Tools/ChangeLog:4 > + Need the bug URL (OOPS!). ^^^^^^
Zoltan Arvai
Comment 3 2012-08-02 05:22:11 PDT
Created attachment 156044 [details] drt-fix-msvc Adding missing bug url to patch. Sorry.
Balazs Kelemen
Comment 4 2012-08-02 05:35:39 PDT
It's strange that on Linux the directory where the pro file exists added by default but on Windows it doesn't. Isn't it a qmake bug?
WebKit Review Bot
Comment 5 2012-08-02 06:13:48 PDT
Comment on attachment 156044 [details] drt-fix-msvc Clearing flags on attachment: 156044 Committed r124447: <http://trac.webkit.org/changeset/124447>
WebKit Review Bot
Comment 6 2012-08-02 06:13:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.