Summary: | StringImpl created from literal should be BufferInternal | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||||
Component: | Web Template Framework | Assignee: | Benjamin Poulain <benjamin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, gyuyoung.kim, joepeck, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 145120 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Benjamin Poulain
2012-08-01 22:03:05 PDT
Created attachment 155975 [details]
Patch
Attachment 155975 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
> Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
This is expected.
I did not change that because ASSERT_EQ does not use our operator==.
Comment on attachment 155975 [details] Patch Attachment 155975 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13411769 Created attachment 156176 [details]
Patch
Attachment 156176 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 156176 [details] Patch Attachment 156176 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13404972 Created attachment 156191 [details]
Patch
Attachment 156191 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 156191 [details] Patch Clearing flags on attachment: 156191 Committed r124611: <http://trac.webkit.org/changeset/124611> All reviewed patches have been landed. Closing bug. |