Summary: | Fix typo in colorSuggestionPicker.js | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Keishi Hattori
2012-08-01 20:46:50 PDT
Created attachment 155961 [details]
Patch
Comment on attachment 155961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155961&action=review > LayoutTests/platform/chromium/TestExpectations:3337 > +BUGWK92444 : platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html = PASS MISSING TEXT IMAGE is necessary for chromium-mac-snowleopard. > LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:2 > +CONSOLE MESSAGE: line 107: Check if window.pagePopupController exists for a page-popup window. > +CONSOLE MESSAGE: line 118: [object PagePopupController] This check is out of scope of the test, isn't it? Created attachment 155966 [details]
Patch
Comment on attachment 155966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155966&action=review > LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:1 > +layer at (0,0) size 800x600 nit: If you are not interested in a render tree dump, testRunner.dumpAsText(true) is ok. Created attachment 155968 [details]
Patch
Comment on attachment 155968 [details] Patch Rejecting attachment 155968 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13423240 Created attachment 155970 [details]
Patch
Comment on attachment 155970 [details] Patch Clearing flags on attachment: 155970 Committed r124409: <http://trac.webkit.org/changeset/124409> All reviewed patches have been landed. Closing bug. |