Bug 92935

Summary: Remove all uses of ClassInfo for JSStrings in JIT code
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Mark Hahnenberg
Reported 2012-08-01 20:00:55 PDT
Patch forthcoming.
Attachments
Patch (21.74 KB, patch)
2012-08-01 20:09 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (21.73 KB, patch)
2012-08-01 20:19 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-08-01 20:09:06 PDT
Created attachment 155956 [details] Patch
Early Warning System Bot
Comment 2 2012-08-01 20:13:41 PDT
Comment on attachment 155956 [details] Patch Attachment 155956 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13426029
Early Warning System Bot
Comment 3 2012-08-01 20:15:01 PDT
Comment on attachment 155956 [details] Patch Attachment 155956 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13425052
Mark Hahnenberg
Comment 4 2012-08-01 20:19:57 PDT
Created attachment 155958 [details] Patch
Geoffrey Garen
Comment 5 2012-08-01 21:50:29 PDT
Comment on attachment 155958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155958&action=review r=me > Source/JavaScriptCore/bytecode/SpeculatedType.cpp:270 > + if (structure->typeInfo().type() == StringType) > + return SpecString; FWIW, you *could* get the JSGlobalData from structure->globalObject()->globalData().
Mark Hahnenberg
Comment 6 2012-08-02 10:32:50 PDT
Committed r124476: <http://trac.webkit.org/changeset/124476>
Note You need to log in before you can comment on or make changes to this bug.