Bug 92912

Summary:

Generalize SheriffIRCBot to prepare for PerfBot

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

92913

Attachments:

Description	Flags
Patch	abarth: review+

Description Ryosuke Niwa 2012-08-01 15:03:14 PDT

Generalize SheriffIRCBot to prepare for PerfBot

Comment 1 Ryosuke Niwa 2012-08-01 15:07:53 PDT

Created attachment 155896 [details]
Patch

Comment 2 WebKit Review Bot 2012-08-01 15:10:31 PDT

Attachment 155896 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py:6:  trailing whitespace  [pep8/W291] [5]
Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py:16:  trailing whitespace  [pep8/W291] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Adam Barth 2012-08-01 15:12:50 PDT

Thank you.  I've wanted to do that for ages.

Comment 4 Ryosuke Niwa 2012-08-01 15:16:15 PDT

Committed r124373: <http://trac.webkit.org/changeset/124373>

Comment 5 Dirk Pranke 2012-08-01 18:00:30 PDT

what do you imagine a PerfBot will do?

Comment 6 Ryosuke Niwa 2012-08-01 18:03:36 PDT

(In reply to comment #5)
> what do you imagine a PerfBot will do?

I'll run performance tests as asked on IRC and report the results.