Bug 92886

Summary: Enable codec tests in TestExpectations and update expected mp3 files
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Raymond Toy <rtoy>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, dalecurtis, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Raymond Toy 2012-08-01 10:48:09 PDT
The infrastructure should be in place to enable the test for the proprietary codecs.  If DRT doesn't support the codecs, the tests should be automatically skipped.

Also, the recent ffmpeg roll that adds support for removing the pre-roll samples from (some) mp3 files changes the expected results for the mp3 codec tests.  These need to be updated.
Comment 1 Raymond Toy 2012-08-01 11:31:55 PDT
Created attachment 155846 [details]
Patch
Comment 2 Raymond Toy 2012-08-01 13:50:39 PDT
Created attachment 155877 [details]
Patch
Comment 3 Chris Rogers 2012-08-01 15:55:40 PDT
Comment on attachment 155877 [details]
Patch

Awesome!
Comment 4 WebKit Review Bot 2012-08-01 17:16:43 PDT
Comment on attachment 155877 [details]
Patch

Clearing flags on attachment: 155877

Committed r124390: <http://trac.webkit.org/changeset/124390>
Comment 5 WebKit Review Bot 2012-08-01 17:16:47 PDT
All reviewed patches have been landed.  Closing bug.