Bug 92886

Summary: Enable codec tests in TestExpectations and update expected mp3 files
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Raymond Toy <rtoy>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, dalecurtis, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Raymond Toy
Reported 2012-08-01 10:48:09 PDT
The infrastructure should be in place to enable the test for the proprietary codecs. If DRT doesn't support the codecs, the tests should be automatically skipped. Also, the recent ffmpeg roll that adds support for removing the pre-roll samples from (some) mp3 files changes the expected results for the mp3 codec tests. These need to be updated.
Attachments
Patch (3.82 KB, patch)
2012-08-01 11:31 PDT, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2012-08-01 13:50 PDT, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raymond Toy
Comment 1 2012-08-01 11:31:55 PDT
Created attachment 155846 [details] Patch
Raymond Toy
Comment 2 2012-08-01 13:50:39 PDT
Created attachment 155877 [details] Patch
Chris Rogers
Comment 3 2012-08-01 15:55:40 PDT
Comment on attachment 155877 [details] Patch Awesome!
WebKit Review Bot
Comment 4 2012-08-01 17:16:43 PDT
Comment on attachment 155877 [details] Patch Clearing flags on attachment: 155877 Committed r124390: <http://trac.webkit.org/changeset/124390>
WebKit Review Bot
Comment 5 2012-08-01 17:16:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.