Bug 92876

Summary:

keyring.get_password may raise an exception.

Product:

WebKit

Reporter:

arno. <a.renevier>

Component:

Tools / Tests

Assignee:

arno. <a.renevier>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch proposal	none

Description arno. 2012-08-01 09:41:01 PDT

Hi,
when using gnome keyring, the method get_password may raise an IOError exception.

One workaround is to wrap self._keyring.get_password in a try catch.
May be we can also wrap set_password in a try/catch also

Comment 1 arno. 2012-08-01 09:46:27 PDT

Created attachment 155824 [details]
patch proposal

In this patch, I catch all exception, (not IOError only), just to be safe

Comment 2 WebKit Review Bot 2012-08-01 10:48:24 PDT

Comment on attachment 155824 [details]
patch proposal

Clearing flags on attachment: 155824

Committed r124343: <http://trac.webkit.org/changeset/124343>

Comment 3 WebKit Review Bot 2012-08-01 10:48:27 PDT

All reviewed patches have been landed.  Closing bug.