Bug 92869

Summary: Clean-up touchadjustment tests
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: kevers, tonikitoo, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2012-08-01 06:37:58 PDT
There are now several touchadjustment tests, many of them use identical or similar auxilary functions during the test. This code should be gathered in a single central file so they can share code. Additionally many of the tests do not have proper doctype or contains other minor mistakes, which can be cleaned up, so the tests appear uniform and form a good example for furture touchadjustment tests.
Attachments
Patch (64.07 KB, patch)
2012-08-01 06:51 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (79.15 KB, patch)
2012-08-01 07:37 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (80.95 KB, patch)
2012-08-01 09:19 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-08-01 06:51:49 PDT
Created attachment 155801 [details] Patch
Allan Sandfeld Jensen
Comment 2 2012-08-01 07:37:34 PDT
Created attachment 155808 [details] Patch Add the last cleaned up files to the patch
Allan Sandfeld Jensen
Comment 3 2012-08-01 09:19:55 PDT
Created attachment 155819 [details] Patch Fix copy-paste error in html-label.html, and put bug-number instead of description in test title
Jocelyn Turcotte
Comment 4 2012-08-01 09:38:52 PDT
Comment on attachment 155819 [details] Patch I'm no expert on this but it makes sense, rs=me.
WebKit Review Bot
Comment 5 2012-08-01 11:45:30 PDT
Comment on attachment 155819 [details] Patch Clearing flags on attachment: 155819 Committed r124351: <http://trac.webkit.org/changeset/124351>
WebKit Review Bot
Comment 6 2012-08-01 11:45:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.