Bug 92810

Summary: [chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, danakj, enne, nduca, shawnsingh, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enne: review+

James Robinson
Reported 2012-07-31 16:33:34 PDT
[chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
Attachments
Patch (24.17 KB, patch)
2012-07-31 16:35 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-07-31 16:35:02 PDT
Created attachment 155673 [details] Patch
Adrienne Walker
Comment 2 2012-07-31 17:12:00 PDT
Comment on attachment 155673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155673&action=review R=me, assuming you tested FPS and debug geometry manually. It'd be nice at some point to have automated HUD tests even if this is just a debug feature. > Source/WebCore/WebCore.gypi:-8268 > - 'platform/graphics/chromium/PlatformCanvas.cpp', > - 'platform/graphics/chromium/PlatformCanvas.h', <3
James Robinson
Comment 3 2012-07-31 17:22:41 PDT
--show-fps-counter, --show-paint-rects and --show-composited-layer-tree appear to behave the same as before. Automated tests of some form would be definitely be nice!
James Robinson
Comment 4 2012-07-31 17:34:56 PDT
Committed r124275: <http://trac.webkit.org/changeset/124275>
Note You need to log in before you can comment on or make changes to this bug.