Bug 92779

Summary: Gesture click test should validate click count in UIEvent.detail
Product: WebKit Reporter: Rick Byers <rbyers>
Component: DOMAssignee: Rick Byers <rbyers>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rick Byers
Reported 2012-07-31 11:45:14 PDT
As part of adding gesture support for sending the dblclick event (Bug 92412), I noticed the fast/events/touch/gesture/gesture-click.html test wasn't explicitly testing the 'detail' field of the event to verify it's '1' for the generate mousedown/mouseup/click events and '0' for mousemove. See http://www.w3.org/TR/DOM-Level-3-Events/#current-click-count
Attachments
Patch (6.15 KB, patch)
2012-07-31 12:58 PDT, Rick Byers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rick Byers
Comment 1 2012-07-31 12:58:27 PDT
Created attachment 155609 [details] Patch
Robert Kroeger
Comment 2 2012-08-01 11:42:00 PDT
Nice. This looks good to me. abarth@: Could you review?
WebKit Review Bot
Comment 3 2012-08-01 13:10:36 PDT
Comment on attachment 155609 [details] Patch Clearing flags on attachment: 155609 Committed r124359: <http://trac.webkit.org/changeset/124359>
WebKit Review Bot
Comment 4 2012-08-01 13:10:40 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 5 2019-02-06 09:19:15 PST
Mass move bugs into the DOM component.
Note You need to log in before you can comment on or make changes to this bug.