| Summary: | [chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint-rects | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cc-bugs, danakj, enne, nduca, shawnsingh, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
James Robinson
2012-07-31 11:20:56 PDT
Created attachment 155588 [details]
Patch
Comment on attachment 155588 [details]
Patch
I mentioned this offline, but I think the bounds should get set every frame rather than in the constructor. While you're touching that code, is it possible to fix the extra commits from the HUD by not adding and removing it every frame?
Created attachment 155619 [details]
Patch
PTAL Comment on attachment 155619 [details]
Patch
R=me. Thanks.
Comment on attachment 155619 [details] Patch Rejecting attachment 155619 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: nes. Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Failed to merge in the changes. Patch failed at 0001 [Chromium] Rebaselines. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13392881 Committed r124269: <http://trac.webkit.org/changeset/124269> Is this actually fixed? I'm still getting crashes with --show-paint-rects and --show-composited-layer-tree. but --show-fps-counter seems to work fine. (In reply to comment #8) > Is this actually fixed? I'm still getting crashes with --show-paint-rects and --show-composited-layer-tree. but --show-fps-counter seems to work fine. Seems OK for me in debug on linux, at least on poster circle. Can you get a stacktrace and open a new bug? (In reply to comment #9) > (In reply to comment #8) > > Is this actually fixed? I'm still getting crashes with --show-paint-rects and --show-composited-layer-tree. but --show-fps-counter seems to work fine. > > Seems OK for me in debug on linux, at least on poster circle. Can you get a stacktrace and open a new bug? My mistake - this was a false alarm. I thought I was on tip-of-tree, but actually I had not rebased my git branch. |