Bug 92764

Summary:

[Chromium] Don't use ninja for building Chromium for Android

Product:

WebKit

Reporter:

Peter Beverloo <peter>

Component:

New Bugs

Assignee:

Peter Beverloo <peter>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84843

Attachments:

Description	Flags
Patch	none

Description Peter Beverloo 2012-07-31 08:59:18 PDT

[Chromium] Don't use ninja for building Chromium for Android

Comment 1 Peter Beverloo 2012-07-31 09:00:48 PDT

Created attachment 155554 [details]
Patch

Comment 2 Peter Beverloo 2012-07-31 09:03:16 PDT

I reverted (and Yaron re-landed) http://crrev.com/148739 on the Chromium side, which enabled creating Ninja project files. This unintentionally switched Android to using the Ninja build, which then broke.

We should eventually make the switch, but do so in a controlled and tested manner.

Comment 3 WebKit Review Bot 2012-07-31 10:27:06 PDT

Comment on attachment 155554 [details]
Patch

Clearing flags on attachment: 155554

Committed r124219: <http://trac.webkit.org/changeset/124219>

Comment 4 WebKit Review Bot 2012-07-31 10:27:10 PDT

All reviewed patches have been landed.  Closing bug.