Bug 92751

Summary: Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, gyuyoung.kim, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 92765    
Bug Blocks: 87262    
Attachments:
Description Flags
Patch yurys: review+, buildbot: commit-queue-

Ilya Tikhonovsky
Reported 2012-07-31 07:23:17 PDT
EOM
Attachments
Patch (17.04 KB, patch)
2012-07-31 07:24 PDT, Ilya Tikhonovsky 		yurys: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-07-31 07:24:56 PDT
Created attachment 155528 [details] Patch
Build Bot
Comment 2 2012-07-31 07:35:30 PDT
Comment on attachment 155528 [details] Patch Attachment 155528 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13404050
Yury Semikhatsky
Comment 3 2012-07-31 08:11:38 PDT
Comment on attachment 155528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155528&action=review > Source/WebCore/inspector/MemoryInstrumentationImpl.h:49 > + size_t totalTypeSize(ObjectType objectType) totalTypeSize -> totalSize
Ilya Tikhonovsky
Comment 4 2012-07-31 08:53:36 PDT
Committed r124208: <http://trac.webkit.org/changeset/124208>
WebKit Review Bot
Comment 5 2012-07-31 09:02:47 PDT
Re-opened since this is blocked by 92765
Ilya Tikhonovsky
Comment 6 2012-08-01 00:30:11 PDT
Committed r124306: <http://trac.webkit.org/changeset/124306>
Note You need to log in before you can comment on or make changes to this bug.