Bug 92715

Summary:

Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

DOM

Assignee:

Kwang Yul Seo <skyul>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

92057

Attachments:

Description	Flags
Patch	abarth: review+

Description Kwang Yul Seo 2012-07-30 23:03:55 PDT

This is a follow-up patch for r123577. Changed oneBelowTop to oneBelowTopStackItem.

Comment 1 Kwang Yul Seo 2012-07-30 23:05:46 PDT

Created attachment 155445 [details]
Patch

Comment 2 Adam Barth 2012-07-31 09:15:18 PDT

Comment on attachment 155445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155445&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:116
> -    Element* oneBelowTop() const { return m_openElements.oneBelowTop(); }
> +    HTMLStackItem* oneBelowTopStackItem() const { return m_openElements.oneBelowTopStackItem(); }

You can also keep the same name since you're removing the old function.  They types are incompatible, so it's not going to confuse anyone.

Comment 3 Kwang Yul Seo 2012-07-31 15:53:40 PDT

(In reply to comment #2)
> You can also keep the same name since you're removing the old function.  They types are incompatible, so it's not going to confuse anyone.

Okay. I will keep the name.

Comment 4 Kwang Yul Seo 2012-07-31 16:00:40 PDT

Committed r124262: <http://trac.webkit.org/changeset/124262>