Bug 92695

Summary: Fix potential compile error on LocalFileSystem::deleteFileSystem
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: WebCore Misc.Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Taiju Tsuiki 2012-07-30 17:27:22 PDT 
The callback type in LocalFileSystem::deleteFileSystem arguments should AsyncFileSystemCallbacks, instead of ErrorCallback.
# Sorry, I contaminated with it a few weeks ago.
Comment 1 Taiju Tsuiki 2012-07-30 17:29:27 PDT 
Created attachment 155407 [details]
Patch
Comment 2 Adam Barth 2012-07-31 09:12:44 PDT 
Comment on attachment 155407 [details]
Patch

Ok.  Can you explain the change a bit more in the ChangeLog?  For example, which builds are broken and why the chromium build works.
Comment 3 Taiju Tsuiki 2012-07-31 10:22:28 PDT 
Created attachment 155581 [details]
Patch
Comment 4 Taiju Tsuiki 2012-07-31 10:25:09 PDT 
(In reply to comment #2)
> (From update of attachment 155407 [details])
> Ok.  Can you explain the change a bit more in the ChangeLog?  For example, which builds are broken and why the chromium build works.

Sure, I updated the ChangeLog.
Comment 5 Adam Barth 2012-07-31 11:52:23 PDT 
Comment on attachment 155581 [details]
Patch

Thanks.
Comment 6 WebKit Review Bot 2012-07-31 12:20:47 PDT 
Comment on attachment 155581 [details]
Patch

Clearing flags on attachment: 155581

Committed r124238: <http://trac.webkit.org/changeset/124238>
Comment 7 WebKit Review Bot 2012-07-31 12:20:50 PDT 
All reviewed patches have been landed.  Closing bug.