Bug 92671

Summary:

Add function to calculate the day in year from a date

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Web Template Framework

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	rniwa: review+, rniwa: commit-queue-

Description Patrick R. Gansterer 2012-07-30 13:20:03 PDT

Add function to calculate the day in year from a date

Comment 1 Patrick R. Gansterer 2012-07-30 13:27:34 PDT

Created attachment 155349 [details]
Patch

Comment 2 Ryosuke Niwa 2012-07-30 13:44:22 PDT

Comment on attachment 155349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155349&action=review

> Source/WTF/ChangeLog:9
> +        dayInYear() makes existing firstDayOfMonth data
> +        accessible from other files than DateMath too.

Please mention that this change helps fixing the bug 92286.

> Source/WTF/wtf/DateMath.cpp:289
> -static inline int monthToDayInYear(int month, bool isLeapYear)
> +int dayInYear(int year, int month, int day)

Let's keep this function static local for now since it's not used elsewhere at the moment.

Comment 3 Patrick R. Gansterer 2012-07-30 14:53:37 PDT

Committed r124095: <http://trac.webkit.org/changeset/124095>