Summary: | [Qt] load event fires on XMLHttpRequestUpload twice with Qt5 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
Component: | Tools / Tests | Assignee: | Marcelo Lira <marcelo.lira> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | marcelo.lira, ossy, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 79666 | ||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-07-30 13:03:41 PDT
They are on the qt-5.0/Skipped list. Please unskip them with the proper fix. Created attachment 165836 [details]
Patch
Comment on attachment 165836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165836&action=review > Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:586 > + if (!bytesTotal) > + return; I would add a comment if (!bytesTotal) { // When finished QNetworkReply emits a progress of 0 bytes. // Ignore that, to avoid firing twice. return; } Created attachment 165853 [details]
Patch
Comment on attachment 165853 [details] Patch Clearing flags on attachment: 165853 Committed r129692: <http://trac.webkit.org/changeset/129692> All reviewed patches have been landed. Closing bug. |