Bug 92634

Summary: [EFL] Support DataList for <input type="range">
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, hausmann, kenneth, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

KwangYong Choi
Reported 2012-07-30 04:48:36 PDT
DataList theme for EFL is implemented. DataList feature of <input type="range"> is supported.
Attachments
Patch (5.42 KB, patch)
2012-07-30 04:58 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.42 KB, patch)
2012-07-30 23:43 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.48 KB, patch)
2012-07-31 02:18 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.45 KB, patch)
2012-08-07 00:53 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-07-30 04:58:31 PDT
Created attachment 155263 [details] Patch
KwangYong Choi
Comment 2 2012-07-30 23:43:19 PDT
Created attachment 155448 [details] Patch Modified ChangeLog
Chris Dumez
Comment 3 2012-07-31 02:10:08 PDT
Comment on attachment 155448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155448&action=review LGTM with small nit. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:805 > + return -12; Probably we should use a static const variable for this magic value.
KwangYong Choi
Comment 4 2012-07-31 02:18:38 PDT
Created attachment 155470 [details] Patch Done. :)
KwangYong Choi
Comment 5 2012-08-07 00:53:48 PDT
Created attachment 156888 [details] Patch Changed description on ChangeLog
Gyuyoung Kim
Comment 6 2012-08-07 01:38:30 PDT
Comment on attachment 156888 [details] Patch LGTM, thanks.
WebKit Review Bot
Comment 7 2012-08-08 05:53:34 PDT
Comment on attachment 156888 [details] Patch Clearing flags on attachment: 156888 Committed r125026: <http://trac.webkit.org/changeset/125026>
WebKit Review Bot
Comment 8 2012-08-08 05:53:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.