Bug 92634 - [EFL] Support DataList for <input type="range">
Summary: [EFL] Support DataList for <input type="range">
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-30 04:48 PDT by KwangYong Choi
Modified: 2012-08-08 05:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.42 KB, patch)
2012-07-30 04:58 PDT, KwangYong Choi 		no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2012-07-30 23:43 PDT, KwangYong Choi 		no flags Details | Formatted Diff | Diff
Patch (5.48 KB, patch)
2012-07-31 02:18 PDT, KwangYong Choi 		no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2012-08-07 00:53 PDT, KwangYong Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KwangYong Choi 2012-07-30 04:48:36 PDT 
DataList theme for EFL is implemented. DataList feature of <input type="range"> is supported.
Comment 1 KwangYong Choi 2012-07-30 04:58:31 PDT 
Created attachment 155263 [details]
Patch
Comment 2 KwangYong Choi 2012-07-30 23:43:19 PDT 
Created attachment 155448 [details]
Patch

Modified ChangeLog
Comment 3 Chris Dumez 2012-07-31 02:10:08 PDT 
Comment on attachment 155448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155448&action=review

LGTM with small nit.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:805
> +    return -12;

Probably we should use a static const variable for this magic value.
Comment 4 KwangYong Choi 2012-07-31 02:18:38 PDT 
Created attachment 155470 [details]
Patch

Done. :)
Comment 5 KwangYong Choi 2012-08-07 00:53:48 PDT 
Created attachment 156888 [details]
Patch

Changed description on ChangeLog
Comment 6 Gyuyoung Kim 2012-08-07 01:38:30 PDT 
Comment on attachment 156888 [details]
Patch

LGTM, thanks.
Comment 7 WebKit Review Bot 2012-08-08 05:53:34 PDT 
Comment on attachment 156888 [details]
Patch

Clearing flags on attachment: 156888

Committed r125026: <http://trac.webkit.org/changeset/125026>
Comment 8 WebKit Review Bot 2012-08-08 05:53:40 PDT 
All reviewed patches have been landed.  Closing bug.