Bug 92626

Summary: [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch gustavo: review+, webkit.review.bot: commit-queue-

Martin Robinson
Reported 2012-07-30 04:06:30 PDT
Instead of shelling out to enter the jhbuild environment, there should be a mode where we directly enter a jhbuild environment within a python script. Then we can use it for run-gtk-tests and get rid of Tools/Scripts/gtk/run-api-tests.
Attachments
Patch (35.79 KB, patch)
2012-07-30 05:43 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (36.31 KB, patch)
2012-07-30 06:00 PDT, Martin Robinson 		gustavo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-07-30 05:43:22 PDT
Created attachment 155272 [details] Patch
Martin Robinson
Comment 2 2012-07-30 06:00:59 PDT
Created attachment 155276 [details] Patch
WebKit Review Bot
Comment 3 2012-07-30 08:56:18 PDT
Comment on attachment 155276 [details] Patch Rejecting attachment 155276 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Tools/GNUmakefile.am patching file Tools/Scripts/run-gtk-tests patching file Tools/gtk/run-api-tests rm 'Tools/gtk/run-api-tests' patching file Tools/jhbuild/jhbuild-wrapper Hunk #4 FAILED at 125. 1 out of 4 hunks FAILED -- saving rejects to file Tools/jhbuild/jhbuild-wrapper.rej patching file Tools/jhbuild/jhbuildutils.py Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13400096
Martin Robinson
Comment 4 2012-07-30 10:17:53 PDT
Committed r124039: <http://trac.webkit.org/changeset/124039>
Note You need to log in before you can comment on or make changes to this bug.