Bug 92626 - [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
Summary: [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-30 04:06 PDT by Martin Robinson
Modified: 2012-07-30 10:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (35.79 KB, patch)
2012-07-30 05:43 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (36.31 KB, patch)
2012-07-30 06:00 PDT, Martin Robinson
gns: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-07-30 04:06:30 PDT
Instead of shelling out to enter the jhbuild environment, there should be a mode where we directly enter a jhbuild environment within a python script. Then we can use it for run-gtk-tests and get rid of Tools/Scripts/gtk/run-api-tests.
Comment 1 Martin Robinson 2012-07-30 05:43:22 PDT
Created attachment 155272 [details]
Patch
Comment 2 Martin Robinson 2012-07-30 06:00:59 PDT
Created attachment 155276 [details]
Patch
Comment 3 WebKit Review Bot 2012-07-30 08:56:18 PDT
Comment on attachment 155276 [details]
Patch

Rejecting attachment 155276 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Tools/GNUmakefile.am
patching file Tools/Scripts/run-gtk-tests
patching file Tools/gtk/run-api-tests
rm 'Tools/gtk/run-api-tests'
patching file Tools/jhbuild/jhbuild-wrapper
Hunk #4 FAILED at 125.
1 out of 4 hunks FAILED -- saving rejects to file Tools/jhbuild/jhbuild-wrapper.rej
patching file Tools/jhbuild/jhbuildutils.py

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13400096
Comment 4 Martin Robinson 2012-07-30 10:17:53 PDT
Committed r124039: <http://trac.webkit.org/changeset/124039>