Bug 92610

Summary: Enable variables tests by default for chromium.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, macpherson, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-01
none
Patch none

Luke Macpherson
Reported 2012-07-29 21:41:30 PDT
Enable variables tests by default for chromium.
Attachments
Patch (1.46 KB, patch)
2012-07-29 21:42 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-01 (469.39 KB, application/zip)
2012-07-30 01:18 PDT, WebKit Review Bot 		no flags
Details
Patch (1.34 KB, patch)
2012-07-30 23:49 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-07-29 21:42:26 PDT
Created attachment 155208 [details] Patch
WebKit Review Bot
Comment 2 2012-07-30 01:18:26 PDT
Comment on attachment 155208 [details] Patch Attachment 155208 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13392278 New failing tests: inspector/styles/variables/css-variables.html
WebKit Review Bot
Comment 3 2012-07-30 01:18:29 PDT
Created attachment 155230 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Dimitri Glazkov (Google)
Comment 4 2012-07-30 09:44:25 PDT
Comment on attachment 155208 [details] Patch The inspector failure looks real. Is this because inspector tests run only on some platforms?
Luke Macpherson
Comment 5 2012-07-30 23:49:35 PDT
Created attachment 155449 [details] Patch
Luke Macpherson
Comment 6 2012-07-30 23:51:41 PDT
Looks like the inspector test has been broken (unsurprising, since it hasn't been running by default). I'll flip it on in a later patch along, but right now I want these on ASAP to prevent other breakage from setting in.
WebKit Review Bot
Comment 7 2012-08-05 19:36:10 PDT
Comment on attachment 155449 [details] Patch Clearing flags on attachment: 155449 Committed r124726: <http://trac.webkit.org/changeset/124726>
WebKit Review Bot
Comment 8 2012-08-05 19:36:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.