Bug 92607 – Make fast/forms/resources/live-pseudo-selectors.css to be succeeded with when applying :read-only/:read-write selectors to all elements

• Component: Tools / Tests
• Status: RESOLVED DUPLICATE

The test select-live-pseudo-selectors.html uses same CSS attribute for non-mutually exclusive pseudo selectors. There is no priority for CSS pseudo class selectors. We should use same CSS attribute for mutually exclusive pseudo selectors.

Created attachment 155210 [details]
Patch 1

Comment on attachment 155210 [details]
Patch 1

Could you review this patch?
Thanks in advance.

[Kent Tamura]

Comment on attachment 155210 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=155210&action=review

> LayoutTests/ChangeLog:11
> +          - Restricts :read-only select to input and textarea elements for
> +            avoiding unexpected CSS attribute changes

I don't understand this paragraph.
- What is 'CSS attribute'? Do you mean CSS property?
- Why applying :read-only to <select> should be avoided.

> LayoutTests/ChangeLog:14
> +          - Use CSS color attribute for :read-only pseudo selector for avoiding
> +            unspecified behavior when both elements matching :read-only and
> +            :invalid/:valid selectors.

Is it really unspecified?  I guess CSS has deterministic rules for such cases.

When we apply :read-only/:read-write selectors all elements, fast/forms/select-live-pseudo-selectors.html failed at background color difference when "option" elements matched to both :read-only and :invalid/:valid.

[Kent Tamura]

(In reply to comment #4)
> When we apply :read-only/:read-write selectors all elements, fast/forms/select-live-pseudo-selectors.html failed at background color difference when "option" elements matched to both :read-only and :invalid/:valid.

Would you explain more please? What test case in select-live-pseudo-selectors.html fails?
"option" never matches to :invalid and :valid. Your explanation is confusing.

Created attachment 155212 [details]
Patch 2

Comment on attachment 155212 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last patch =
* The changes is only in live-pseudo-selectors.css
** Revert {input,textarea}-live-pseudo-selectors{.html,-expected.txt}
* Update ChangeLog

[Kent Tamura]

Comment on attachment 155212 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=155212&action=review

> LayoutTests/ChangeLog:16
> +        When we don't do this, select-live-pseudo-selectors.html renders background
> +        of select element as background color specified in :read-only selector
> +        instead of background color specified in :invalid or :valid.

ok, I understand the intention of this change now.
It was hard to understand the benefit of this change to me. If this change was made at the same time as the improvement of :read-only/:read-write, the benefit would be clear.
I don't think we need to commit this prior to the :read-only/:read-write improvement. You just change it when you needed. This change is small enough.

I'll merge this change to bug 92602.

*** This bug has been marked as a duplicate of bug 92602 ***