Summary: | [Chromium] Web Inspector: Win Dbg tests timing out (r123556 or r123560?) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, haraken, japhet, jochen, joepeck, kbr, keishi, loislo, msaboff, pfeldman, pmuellr, rik, timothy, ulan, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Peter Kasting
2012-07-27 22:04:22 PDT
Created attachment 155331 [details]
Patch
I can believe that my patch http://trac.webkit.org/changeset/123556 could be the culprit. Here's a patch that should avoid having it affect these Inspector tests; shall we land this and see whether it clears up the timeouts? Comment on attachment 155331 [details]
Patch
Do you have anyone to stamp this change? I can do that in case it is safe and you provide a brief explanation on why it is so. Thanks.
It restricts the earlier heuristics which force full GCs to only apply to pages using WebGL, not pages using 2D canvas contexts. This is sufficient for our needs at the moment, and I think will clear up the Inspector timeouts if those pages are using 2D canvas. Comment on attachment 155331 [details] Patch Rejecting attachment 155331 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ueue/ Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp Hunk #1 FAILED at 87. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13424550 Created attachment 156426 [details]
Patch for landing
Comment on attachment 156426 [details] Patch for landing Clearing flags on attachment: 156426 Committed r124653: <http://trac.webkit.org/changeset/124653> All reviewed patches have been landed. Closing bug. |