Bug 92551 – [Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Caio Marcelo de Oliveira Filho]

The last line of those tests are expected to have some trailing spaces. Works in Qt WK2 but not with WK1.

[Marcelo Lira]

The problem here is that the text input boxes are rendered differently in chromium and qt/gtk/efl, causing the text dump to also differ.

There are 4 adjacent input boxes in a page 800 pixel wide, the width of these inputs is unspecified, as it should since this is unrelated  to purpose of the test, and left for the port to decide. Chromium puts the four in the same line, qt/gtk/efl breaks the line before the fourth input, causing an extra space to appear in the text dump.

A fix to this test consists in just putting a <br> after each input element, which will ensure the text dumps will be identical in all  platforms, eliminating the need for special expected files.

[Marcelo Lira]

Created attachment 164421 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Comment on attachment 164421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164421&action=review

Nice catch! I have a suggestion.

> LayoutTests/ChangeLog:19
> +        A fix to this test consists in just putting a <br> after each
> +        input element, which will ensure the text dumps will be identical in all
> +        platforms, eliminating the need for special expected files.

I think you could instead set the width of the inputs to 100px or something like that instead. This would avoid all the empty lines in the expected result, which are simply noise.

[Marcelo Lira]

Created attachment 164429 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Comment on attachment 164429 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 164429 [details]
Patch

Rejecting attachment 164429 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/mailto/advanced-get-expected.txt
rm 'LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt'
patching file LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt
rm 'LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt'
patching file LayoutTests/platform/qt-mac/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13897640

[Marcelo Lira]

Created attachment 164776 [details]
Patch

[Marcelo Lira]

Comment on attachment 164776 [details]
Patch

This is just a rebase of the previous patch, already reviewed by Adam Barth.

[WebKit Review Bot]

Comment on attachment 164776 [details]
Patch

Clearing flags on attachment: 164776

Committed r129120: <http://trac.webkit.org/changeset/129120>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.