| Summary: | chromium win compile broken after removing webkit.py | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric, maruel, ojan, rniwa, tomhudson, tony, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Pranke
2012-07-27 14:44:59 PDT
Created attachment 155053 [details]
Patch
filed https://code.google.com/p/chromium/issues/detail?id=139426 for the problem with browser_tests.isolate (a file in chromium) listing files in webkit directly ... I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org. We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice. Comment on attachment 155053 [details] Patch I land-cowboyed this but I guess it didn't update the bug (and I forgot to --no-review it) ... http://trac.webkit.org/changeset/123918 (In reply to comment #3) > I don't we should accommodate folks who try to use webkitpy from outside svn.webkit.org. We've been very clear from the beginning that webkitpy does not have a public API and attempts to use it from outside svn.webkit.org will break without notice. See the comment I just left on the chromium bug; he's not trying to use webkitpy, he's trying to run NRWT. now, how we're approaching the "sparse checkout" / isolate problem, and how it should interact w/ webkit, on the other hand, is something worth discussing. I commented in the Chromium bug. The summary is that the existence of webkitpy is an implementation detail of WebKit and any mention of webkitpy outside svn.webkit.org can and will be broken without notice. i believe maruel has fixed the downstream error, so I'm going to remove the stub now ... Created attachment 155406 [details]
Patch
rubber stamp, anyone? Comment on attachment 155406 [details] Patch Clearing flags on attachment: 155406 Committed r124158: <http://trac.webkit.org/changeset/124158> All reviewed patches have been landed. Closing bug. |