Summary: | Change navigator.webkitGamepads[] to navigator.webkitGetGamepads() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Scott Graham <scottmg> | ||||||
Component: | New Bugs | Assignee: | Scott Graham <scottmg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Scott Graham
2012-07-27 12:16:43 PDT
Created attachment 155019 [details]
Patch
Comment on attachment 155019 [details]
Patch
Ok. I presume we're ok changing this API at this stage of its development.
Thanks. It hasn't shipped outside of a flag yet and of course still prefixed, so I think it's OK to change. Comment on attachment 155019 [details]
Patch
Thanks.
Comment on attachment 155019 [details] Patch Rejecting attachment 155019 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 148739 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 148739. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13377652 Created attachment 155064 [details]
Patch
(Just removed OOPS! line) Comment on attachment 155064 [details] Patch Clearing flags on attachment: 155064 Committed r123937: <http://trac.webkit.org/changeset/123937> All reviewed patches have been landed. Closing bug. |