Bug 92533 - Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
Summary: Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 12:16 PDT by Scott Graham
Modified: 2012-07-27 16:52 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.54 KB, patch)
2012-07-27 12:20 PDT, Scott Graham
no flags Details | Formatted Diff | Diff
Patch (13.50 KB, patch)
2012-07-27 15:24 PDT, Scott Graham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2012-07-27 12:16:43 PDT
Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
Comment 1 Scott Graham 2012-07-27 12:20:23 PDT
Created attachment 155019 [details]
Patch
Comment 2 Adam Barth 2012-07-27 14:05:09 PDT
Comment on attachment 155019 [details]
Patch

Ok.  I presume we're ok changing this API at this stage of its development.
Comment 3 Scott Graham 2012-07-27 14:09:43 PDT
Thanks. It hasn't shipped outside of a flag yet and of course still prefixed, so I think it's OK to change.
Comment 4 Adam Barth 2012-07-27 14:10:48 PDT
Comment on attachment 155019 [details]
Patch

Thanks.
Comment 5 WebKit Review Bot 2012-07-27 15:21:00 PDT
Comment on attachment 155019 [details]
Patch

Rejecting attachment 155019 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 148739 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 148739.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13377652
Comment 6 Scott Graham 2012-07-27 15:24:27 PDT
Created attachment 155064 [details]
Patch
Comment 7 Scott Graham 2012-07-27 15:25:16 PDT
(Just removed OOPS! line)
Comment 8 WebKit Review Bot 2012-07-27 16:52:05 PDT
Comment on attachment 155064 [details]
Patch

Clearing flags on attachment: 155064

Committed r123937: <http://trac.webkit.org/changeset/123937>
Comment 9 WebKit Review Bot 2012-07-27 16:52:09 PDT
All reviewed patches have been landed.  Closing bug.