RESOLVED FIXED92533
Change navigator.webkitGamepads[] to navigator.webkitGetGamepads() 
https://bugs.webkit.org/show_bug.cgi?id=92533
Summary Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
Scott Graham
Reported 2012-07-27 12:16:43 PDT
Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
Attachments
Patch (13.54 KB, patch)
2012-07-27 12:20 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Patch (13.50 KB, patch)
2012-07-27 15:24 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Scott Graham
Comment 1 2012-07-27 12:20:23 PDT
Created attachment 155019 [details] Patch
Adam Barth
Comment 2 2012-07-27 14:05:09 PDT
Comment on attachment 155019 [details] Patch Ok. I presume we're ok changing this API at this stage of its development.
Scott Graham
Comment 3 2012-07-27 14:09:43 PDT
Thanks. It hasn't shipped outside of a flag yet and of course still prefixed, so I think it's OK to change.
Adam Barth
Comment 4 2012-07-27 14:10:48 PDT
Comment on attachment 155019 [details] Patch Thanks.
WebKit Review Bot
Comment 5 2012-07-27 15:21:00 PDT
Comment on attachment 155019 [details] Patch Rejecting attachment 155019 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 148739 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 148739. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13377652
Scott Graham
Comment 6 2012-07-27 15:24:27 PDT
Created attachment 155064 [details] Patch
Scott Graham
Comment 7 2012-07-27 15:25:16 PDT
(Just removed OOPS! line)
WebKit Review Bot
Comment 8 2012-07-27 16:52:05 PDT
Comment on attachment 155064 [details] Patch Clearing flags on attachment: 155064 Committed r123937: <http://trac.webkit.org/changeset/123937>
WebKit Review Bot
Comment 9 2012-07-27 16:52:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.